substance / notes

Real-time collaborative notes editing.
Other
21 stars 5 forks source link

Dashboard end point: Provide collaborators as an array #83

Closed michael closed 8 years ago

michael commented 8 years ago
"collaborators":"Test User 1, Test User 2"

should become

"collaborators": ["Test User 1", "Test User 2"]
Integral commented 8 years ago

why?

On Fri, Apr 1, 2016 at 6:32 PM Michael Aufreiter notifications@github.com wrote:

Assigned #83 https://github.com/substance/notes/issues/83 to @Integral https://github.com/Integral.

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/substance/notes/issues/83#event-611425103

michael commented 8 years ago

we should just provide the most convenient way for the client.

currently i need to hack it there for formatting.

https://github.com/substance/notes/blob/master/client/Dashboard.js#L66

michael commented 8 years ago

Also this here will fail if there are no collaborators because collaborators could be null.

https://github.com/substance/notes/blob/master/client/Cover.js#L23

So we should always return an empty array if there are no collaborators.

michael commented 8 years ago

Try creating a new note and you will see the error.

Integral commented 8 years ago

Done.