Ability to delete notes

substance / notes

Real-time collaborative notes editing.

Other

20 stars 5 forks source link

Ability to delete notes #87

Closed michael closed 8 years ago

michael commented 8 years ago

We could offer this in dashboard, but only for docs that you created yourself.

michael commented 8 years ago

I added links in the dashboard. Now over to @Integral for the server side bits.

There already is a deleteDocument endpoint in DocumentEngine. However, that only deletes the document record, not the changes.

First please add a test to DocumentEngine.test that checks if on deletion of a document also the changes are gone.
We also need to add deleteDocument API endpoint to DocumentServer
Same for DocumentClient
And then finally connect the UI (I will do that once the server stuff is ready)

Integral commented 8 years ago

@michael we can't call DocumentEngine.getChanges after document was deleted because it's guarded by documentExists. But we could call documentEngine.changeStore.getChanges, not sure that it's a good idea, however what's the difference, it's only a test... what do you think?

Integral commented 8 years ago

Ok. It's almost done. You should only do something here https://github.com/substance/notes/blob/b5223a2b25e7a554b82daf1ae8482cb5db882209/client/Notes.js#L285 to update dashboard list.

michael commented 8 years ago

Implemented.