search

substance / texture

A visual editor for research.
MIT License
1k stars 85 forks source link

App improvements #1164

Closed obuchtala closed 5 years ago

obuchtala commented 5 years ago

This PR improves the bundled Texture MacOS app with respect to command line usage. Moreover, all npm dependencies have been upgraded to latest versions (except esm and nyc).

On MacOS Texture can be used like this:

open -a /Applications/Texture.app MyArticle.dar

Additionally, it allows to open an 'inflated' DAR, i.e. the content of the DAR extracted into a folder.

open -a /Applications/Texture.app ./Documents/MyArticle/
codecov[bot] commented 5 years ago

Codecov Report

Merging #1164 into master will increase coverage by 0.28%. The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   84.08%   84.37%   +0.28%     
==========================================
  Files         394      400       +6     
  Lines        8950     9109     +159     
==========================================
+ Hits         7526     7686     +160     
+ Misses       1424     1423       -1
Impacted Files Coverage Δ
src/article/shared/FigurePanelComponent.js 100% <ø> (ø) :arrow_up:
src/article/converter/JATSImportDialog.js 4.54% <ø> (ø) :arrow_up:
src/article/shared/SupplementaryFileComponent.js 100% <ø> (ø) :arrow_up:
src/kit/ui/PinnedMessage.js 0% <ø> (ø) :arrow_up:
src/Texture.js 88.23% <ø> (ø) :arrow_up:
src/article/shared/AddSupplementaryFileWorkflow.js 100% <ø> (ø) :arrow_up:
src/article/shared/TableFigureComponent.js 100% <ø> (ø) :arrow_up:
src/article/editor/SaveHandler.js 0% <ø> (ø) :arrow_up:
src/kit/ui/FormRowComponent.js 100% <ø> (ø) :arrow_up:
src/article/shared/PreviewComponent.js 100% <ø> (ø) :arrow_up:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50e82ae...8c98a9e. Read the comment docs.

obuchtala commented 5 years ago

Want to add a test for the storage implementations.

obuchtala commented 5 years ago

Needed to rollback upgrade of nyc and esm because the combination of the latest versions was creating an empty report, but only on travis, i.e. it was working locally. Might be an npm related problem. Will try again to upgrade these modules with the next release.