Closed Integral closed 5 years ago
Merging #1169 into master will increase coverage by
0.84%
. The diff coverage is95.18%
.
@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
+ Coverage 84.61% 85.46% +0.84%
==========================================
Files 400 404 +4
Lines 8966 9014 +48
==========================================
+ Hits 7587 7704 +117
+ Misses 1379 1310 -69
Impacted Files | Coverage Δ | |
---|---|---|
src/article/metadata/InplaceRefContribsEditor.js | 82.6% <ø> (ø) |
:arrow_up: |
src/article/ArticlePanel.js | 81.81% <ø> (ø) |
:arrow_up: |
src/article/shared/InsertFootnoteCommand.js | 100% <ø> (ø) |
:arrow_up: |
src/article/converter/r2t/UnderlineConverter.js | 100% <100%> (ø) |
|
...rc/article/converter/r2t/StrikeThroughConverter.js | 100% <100%> (ø) |
|
src/article/shared/ManuscriptContentPackage.js | 100% <100%> (ø) |
:arrow_up: |
src/article/shared/ArticleToolbarPackage.js | 100% <100%> (ø) |
:arrow_up: |
src/article/shared/DOIInputComponent.js | 65.85% <100%> (+53.35%) |
:arrow_up: |
src/article/shared/entityRenderers.js | 85.09% <100%> (+0.37%) |
:arrow_up: |
src/article/converter/r2t/OverlineConverter.js | 100% <100%> (ø) |
|
... and 24 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8d173bf...3a9b4ec. Read the comment docs.
@Integral pls rebase to latest master, so you get correct coverage results.
@Integral let's add the tests before merging this. I'd rather like to see tests for stuff from past PRs, than implementing a new feature. Otherwise we end up having no time for writing the tests later, when we have to implement new features.
Let me know if you need any help with these tests.
@oliver---- letting you know: I need help with tests. Also there are problems with rerendering after view switching
@Integral I'll take a look
This is now as good as we can get currently.
Weekly backlog tasks.