search

substance / texture

A visual editor for research.
MIT License
1k stars 85 forks source link

Internal: move entity renderers to models #1173

Open Integral opened 5 years ago

Integral commented 5 years ago

E.g. what we did with Organisation should be done to other models as well for the sake of consistency.

Integral commented 5 years ago

@oliver---- There are two types of renderers here: 1) When you get a plain text string 2) When you get a markup (for all references)

The first one I moved to member functions, the second pretty complex and I think we should left them as they are for now. Ok?

obuchtala commented 5 years ago

Sounds good!

Daniel Beilinson notifications@github.com schrieb am Do., 18. Apr. 2019, 14:01:

@oliver---- https://github.com/oliver---- There are two types of renderers here:

  1. When you get a plain text string
  2. When you get a markup (for all references)

The first one I moved to member functions, the second pretty complex and I think we should left them as they are for now. Ok?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/substance/texture/issues/1173#issuecomment-484475531, or mute the thread https://github.com/notifications/unsubscribe-auth/AACFLQZM646V75GBEXW4LVTPRBPLFANCNFSM4GYBS52A .