substance / texture

A visual editor for research.
MIT License
1k stars 85 forks source link

Router #1181

Closed obuchtala closed 5 years ago

obuchtala commented 5 years ago

Introduces a router that parses the URL and opens the according location in Texture. This is particularly useful during development. But also later we can use this for permanent links.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1181 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.02%     
==========================================
  Files         398      398              
  Lines        8931     8939       +8     
==========================================
+ Hits         7707     7716       +9     
+ Misses       1224     1223       -1
Impacted Files Coverage Δ
src/article/editor/ManuscriptEditor.js 92.15% <ø> (-1.07%) :arrow_down:
src/article/metadata/MetadataSectionTOCEntry.js 92.3% <ø> (-0.55%) :arrow_down:
src/article/ArticlePanel.js 85.91% <100%> (+4.09%) :arrow_up:
src/article/editor/ManuscriptSection.js 100% <100%> (ø) :arrow_up:
src/TextureWebAppChrome.js 42.42% <100%> (+15.5%) :arrow_up:
src/article/metadata/MetadataSection.js 100% <100%> (ø) :arrow_up:
src/article/editor/ManuscriptTOC.js 96.15% <100%> (-0.73%) :arrow_down:
src/article/metadata/MetadataEditor.js 93.22% <0%> (+1.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e2352d...07e6dbf. Read the comment docs.

Integral commented 5 years ago

@oliver---- want to discuss this, have small problems here.

Integral commented 5 years ago

In short: this will fail now, because of event preventing which I cancelled to be able to change url. There is something behind this event preventing which I don't know.

obuchtala commented 5 years ago

This is working now.