search

substance / texture

A visual editor for research.
MIT License
1k stars 83 forks source link

Fix 1251 #1264

Closed obuchtala closed 5 years ago

obuchtala commented 5 years ago

Fixes #1251

Plus test case and fix for #1216.

Integral commented 5 years ago

Update/reminder: there is a problem with #1251 which should be fixed in a Substance land: the annotations seem to get shuffled which is the reason why persistence test is failing. The order of annotations should be controllable. Afterwards we should add another test case to check if the order is correct. Meanwhile we fixed #1216 here.

obuchtala commented 5 years ago

@Integral Code is looking good :) will do the Substance fixes and then get this ready for merge

codecov[bot] commented 5 years ago

Codecov Report

Merging #1264 into master will increase coverage by <.01%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage      89%   89.01%   +<.01%     
==========================================
  Files         401      401              
  Lines        8979     8983       +4     
==========================================
+ Hits         7992     7996       +4     
  Misses        987      987
Impacted Files Coverage Δ
src/article/models/ExternalLink.js 50% <0%> (-50%) :arrow_down:
...rc/article/converter/jats/ExternalLinkConverter.js 100% <100%> (+10%) :arrow_up:
src/article/converter/jats/TableConverter.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82873de...c45bf5d. Read the comment docs.