Keywords (WIP)

[Integral]

• [x] Rename property CustomMetadataField.value to ‘values’ and store there array
• [x] Update FigurePanelImporter to map keywords to an array of values
• [x] Update FigurePanelExporter to export the array of values
• [x] Implement a component for the proposed overlay/popup following the described UX
• [x] Introduce a command to remove the current value (click on ‘remove’ button should trigger this) if the cursor is in the removed value, it should be moved to the next ‘reasonable’ place
• [x] Make sure that keyboard navigation via UP/DOWN and TAB/SHIFT-TAB allows to navigate through the different values
• [x] (O): click on value needs to change selection and/or overlayId so that popup is shown
• [ ] Add a keyboard shortcut to remove the current value (CommandOrCtrl+Delete)

Tests:

• [x] fix existing tests for keyword editing

Mockup:

[obuchtala]

@Integral I have implemented this as a prototype, because the required solution is kind of new, while very similar to IsolatedNodes. Let's get everything working, and then see how we could extract a parent class, so that this kind of interface will be easier to implement the next time.

[obuchtala]

@Integral I tried another approach based on CustomSurface and selections. A little more like IsolatedNodeComponent is working. The implementation is still very hacky. @michael Before we tidy up, we need to 100% nail down how the UX should be in detail, e.g. keyboard handling, undo/redo, etc.

[codecov[bot]]

Codecov Report

Merging #1268 into master will decrease coverage by 1.08%. The diff coverage is 38.3%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage    89.5%   88.41%   -1.09%     
==========================================
  Files         400      404       +4     
  Lines        9027     9214     +187     
==========================================
+ Hits         8080     8147      +67     
- Misses        947     1067     +120

Impacted Files	Coverage Δ
src/article/models/CustomMetadataField.js	100% <ø> (ø)	:arrow_up:
src/article/models/ArticleModelPackage.js	100% <ø> (ø)	:arrow_up:
src/kit/ui/Input.js	33.33% <0%> (-1.15%)	:arrow_down:
src/kit/ui/OverlayMixin.js	90.9% <100%> (+10.9%)	:arrow_up:
src/article/shared/ArticleToolbarPackage.js	100% <100%> (ø)	:arrow_up:
src/kit/ui/Popup.js	100% <100%> (ø)
src/article/converter/jats/FigurePanelConverter.js	98.73% <100%> (+0.01%)	:arrow_up:
src/kit/ui/MultiSelectInput.js	97.61% <100%> (-0.06%)	:arrow_down:
src/article/manuscript/ManuscriptPackage.js	100% <100%> (ø)	:arrow_up:
src/article/shared/FigureMetadataComponent.js	100% <100%> (ø)	:arrow_up:
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58506ef...0e7268c. Read the comment docs.

[obuchtala]

After playing around with the current interface we came to the conclusion, that the UI feels somewhat unnatural. The reason is not really clear, probably, because it is more like a 'sheet' or 'table' layout, but the UX is not that of a sheet, more like a form. We see two options, moving towards a sheet UI, or making the current feel more like a form. The first, is interesting but too much for this iteration.

The latter we should give a try, but only as polishing for the current prototype. Potentially a problem with the current design could also be, that the popover/dropdown feel is not appropriate for something more complex like this. We could instead use more space for the popup, maybe more like a little modal, position at the same location, but just let it looks less like a tooltip-like popover.

Refinements: [ ] Remove the 'delete' buttons and instead add a contextual tool (the buttons clutter the UI too much) [ ] Try to add a bit more spacing and let the fields look more like form fields [ ] The popup is moving down when keywords are added