codecov[bot]
commented
5 years ago Codecov Report
Merging #1295 into master will decrease coverage by
0.08%. The diff coverage is92.63%.
@@ Coverage Diff @@
## master #1295 +/- ##
=========================================
- Coverage 89.59% 89.5% -0.09%
=========================================
Files 400 400
Lines 9023 9027 +4
=========================================
- Hits 8084 8080 -4
- Misses 939 947 +8| Impacted Files | Coverage Δ | |
|---|---|---|
| src/kit/ui/ToolGroup.js | 88.57% <ø> (-0.32%) |
:arrow_down: |
| src/article/shared/EditEntityCommand.js | 100% <ø> (ø) |
:arrow_up: |
| src/kit/ui/ScrollPane.js | 52.94% <ø> (-1.86%) |
:arrow_down: |
| src/kit/ui/BodyScrollPane.js | 0% <ø> (ø) |
:arrow_up: |
| src/article/manuscript/ManuscriptPackage.js | 100% <ø> (ø) |
:arrow_up: |
| src/article/metadata/MetadataPackage.js | 100% <ø> (ø) |
:arrow_up: |
| src/kit/ui/_TextPropertyEditor.js | 73.33% <0%> (-26.67%) |
:arrow_down: |
| src/kit/ui/_IsolatedInlineNodeComponent.js | 100% <100%> (ø) |
:arrow_up: |
| src/article/shared/DOIInputComponent.js | 90.69% <100%> (+0.45%) |
:arrow_up: |
| src/article/shared/InlineFormulaEditor.js | 100% <100%> (ø) |
|
| ... and 30 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b5b3edc...1c47569. Read the comment docs.
obuchtala
Why
The current Overlay implementation is made for tools, and does not work for more complex overlay content, including popups with Surfaces in it.
What
This PR replaces the former Overlay implementation with a generalized OverlayCanvas implementation. All former 'prompt' tools are replaced with components that acquire the OverlayCanvas when necessary.