search

substance / texture

A visual editor for research.
MIT License
999 stars 85 forks source link

add issn field #1354

Open malayibiri opened 5 years ago

malayibiri commented 5 years ago

Why

ISSN field is needed in JournalArticleRef.

What

I just add ISSN field like ISBN in Books. Also in convertCSLJSON allow import CSLJSON files without DOIs, what are the problems in the further processing? everything seems to work ok in my local copy.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1354 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   86.53%   86.53%   +<.01%     
==========================================
  Files         387      387              
  Lines        7426     7428       +2     
==========================================
+ Hits         6426     6428       +2     
  Misses       1000     1000
Impacted Files Coverage Δ
src/article/converter/bib/BibConversion.js 80.55% <ø> (ø) :arrow_up:
src/article/nodes/JournalArticleRef.js 100% <ø> (ø) :arrow_up:
src/article/shared/EntityLabelsPackage.js 100% <100%> (ø) :arrow_up:
...article/converter/jats/ElementCitationConverter.js 95.72% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9652776...b3038bc. Read the comment docs.