Closed carlopi closed 2 months ago
I think this should sort of work, although it might need some minor touches.
Thanks for picking this up!
I think the SQL tests are not running?
No test cases matched '/Users/runner/work/substrait/substrait/test/*'
@pdet: nice catch, up to the next
LGTM! Thanks Carlo!!
@carlopi I just gave this a go and got
con.execute("FORCE INSTALL substrait FROM core_nightly")
duckdb.duckdb.HTTPException: HTTP Error: Failed to download extension "substrait" at URL "http://nightly-extensions.duckdb.org/v1.1.0/osx_arm64/substrait.duckdb_extension.gz" (HTTP 403)
Extension "substrait" is an existing extension.
Yes, I had seen it earlier, I think https://github.com/duckdb/substrait/pull/110 solves this.
I think it worked:
FORCE INSTALL substrait from core_nightly;
LOAD substrait;
SELECT extension_name, extension_version, install_mode, installed_from FROM duckdb_extensions() WHERE extension_name = 'substrait';
┌────────────────┬───────────────────┬──────────────┬────────────────┐
│ extension_name │ extension_version │ install_mode │ installed_from │
│ varchar │ varchar │ varchar │ varchar │
├────────────────┼───────────────────┼──────────────┼────────────────┤
│ substrait │ d8ca65b │ REPOSITORY │ core_nightly │
└────────────────┴───────────────────┴──────────────┴────────────────┘
Include https://github.com/duckdb/substrait/pull/108, plus fixes to build system.
Note that while building there are a few warnings connected to targets like:
Those might need to double checked, relevant code is likely already in extension-ci-tools, but I am not completely sure.