Add optional test executable and enable Substrait C API tests

substrait-io / duckdb-substrait-extension

MIT License

28 stars 22 forks source link

Closed anshuldata closed 1 week ago

anshuldata commented 1 week ago

This allows running C Unit tests
Added an option ENABLE_TEST_EXE to build an optional test executable in test/c/CMakeLists.txt
Created a new main.cpp file to run C tests.
Updated test_substrait_c_api.cpp to fix build errors and remove unused includes.
Included the new test directory in the main CMakeLists.txt.

jacques-n commented 1 week ago

Why are some of the checks failing?

anshuldata commented 1 week ago

Why are some of the checks failing?

It is failing in unchanged file and this PR doesn't change workflow. So don't have a clue based on failure. I will debug it.

anshuldata commented 1 week ago

Why are some of the checks failing?

Issue was workflow refers to latest main instead of a specific commit. Duckdb moved ahead with breaking change. I will raise another PR to fix it

anshuldata commented 1 week ago

Raised #122 to fix Workflow to run with a particular commit of duckdb. Once it is merged, I will rebase this one