search

substrait-io / substrait-java

Apache License 2.0
75 stars 72 forks source link

bug: fix vist of nested struct #150

Closed MasseGuillaume closed 1 year ago

MasseGuillaume commented 1 year ago

This test case will hit:

https://github.com/substrait-io/substrait-java/blob/4749dcad7eec5325414b0b08d7c2f0fdfc058378/isthmus/src/main/java/io/substrait/isthmus/expression/RexExpressionConverter.java#L128-L129

since fieldAccess.getReferenceExpr() is a RexFieldAccess

MasseGuillaume commented 1 year ago

Ready for review!

MasseGuillaume commented 1 year ago

@jacques-n if you can review this PR, your feedback would be greatly appreciated.