substrait-io / substrait-java

Apache License 2.0
74 stars 70 forks source link

fix: Left/right/outer joins should have nullable fields. #157

Closed carlyeks closed 1 year ago

carlyeks commented 1 year ago

During a left, right, or outer join, some set of fields from input become nullable because they are optionally matched in the output. For a left join, the right fields become nullable. For a right join, the left fields become nullable. For an outer join, both sets become nullable.

This test fails with assertions enabled in Calcite code because the left join should have nullable right types.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.