Does substrait-java core rely on full antlr4 at runtime?

substrait-io / substrait-java

Apache License 2.0

74 stars 70 forks source link

Does substrait-java core rely on full antlr4 at runtime? #162

Closed adamkennedy closed 10 months ago

adamkennedy commented 11 months ago

The current substrait core module has a dependency on antlr4 at run-time, which pulls in a lot of extra dependencies in the form of things like the icu library.

Could this be changed to depend on only antlr4-runtime instead?

jacques-n commented 11 months ago

We have a relatively simple grammar. I don't think I ever evaluated alternatives. I would expect antlr runtime to work. Want to post a patch trying it out?

vbarua commented 10 months ago

Handled in https://github.com/substrait-io/substrait-java/pull/182