search

substrait-io / substrait-java

Apache License 2.0
74 stars 70 forks source link

feat: support reading Substrait plans with Window Functions #165

Closed vbarua closed 11 months ago

vbarua commented 11 months ago

The changes in this PR allows substrait-java to read in Substrait plans containing window functions (the existing machinary only allowed for generating these plans).

Various roundtrip tests are included in WindowFunctionTest. These tests helped my identify some bugs in the existing code to convert POJO window bounds to PROTO window bounds. I've simplified the handling of these as well.

jacques-n commented 11 months ago

@jinfengni , can you please review?

vbarua commented 11 months ago

Note: this work depends on the refactor in https://github.com/substrait-io/substrait-java/pull/164

vbarua commented 11 months ago

PR to add this behaviour to the spec is https://github.com/substrait-io/substrait/pull/540