refactor: unify aggregate and window functions in window handling - Githubissues

substrait-io / substrait-java

Apache License 2.0

74 stars 70 forks source link

refactor: unify aggregate and window functions in window handling #170

Closed vbarua closed 10 months ago

vbarua commented 10 months ago

feat: allow window function operands beyond just column references fix: invocation was not set when building WindowFunction proto

BREAKING CHANGES:

Window and WindowFunction have been merged into WindowFunctionInvocation
WindowFunctionInvocation is now an inner class of expression
WindowFunctionInvocation now implements Expression.
Expression visitor now visit WindowFunctionInvocation
WindowFunctionConvert constructor requires fewer arguments
windowCreator has additional fields
POJO WindowBound offset must now be a long, better reflecting spec