substrait-io / substrait-java

Apache License 2.0
72 stars 70 forks source link

enable assertions for test #181

Closed vbarua closed 9 months ago

vbarua commented 9 months ago

Updating the build to enable assertions in build.gradle.kts by adding the enableAssertions flags like:

  tasks.configureEach<Test> {
    ...
    enableAssertions = true
  }

results in test failing with assertion failures.

It would be good to fix these errors so that assertions can be enable permanently for test, as they are quite helpful when working with Calcite.

vbarua commented 9 months ago

This errors may just have been due to actual issues in https://github.com/substrait-io/substrait-java/pull/180

vbarua commented 9 months ago

These are actually enabled already. Please ignore.