search

substrait-io / substrait-java

Apache License 2.0
75 stars 72 forks source link

feat: add NestedLoopJoin rel #188

Closed danepitkin closed 11 months ago

danepitkin commented 11 months ago

Requires https://github.com/substrait-io/substrait/pull/561 to be merged and released.

vbarua commented 11 months ago

https://github.com/substrait-io/substrait/pull/561 has been merged. After it's released over the weekend, we can update the submodule to point to it (preferably as it's own PR).

vbarua commented 11 months ago

I went ahead and updated substrait-java with the latest version of substrait, which includes the NestedLoopJoin changes.

danepitkin commented 11 months ago

I can repro the failure locally. I'm still digging into it, it seems the test case is surfacing an actual bug.

The issue is in the last param in this equal comparator output:

condition=ScalarFunctionInvocation{declaration=equal:any_any, arguments=[FieldReference{segments=[StructField{offset=0}], type=I64{nullable=false}}, FieldReference{segments=[StructField{offset=2}], type=I64{nullable=false}}]
condition=ScalarFunctionInvocation{declaration=equal:any_any, arguments=[FieldReference{segments=[StructField{offset=0}], type=I64{nullable=false}}, FieldReference{segments=[StructField{offset=2}], type=Str{nullable=false}}]
danepitkin commented 11 months ago

Thank you so much for the help!