search

substrait-io / substrait-java

Apache License 2.0
72 stars 70 forks source link

test: move common logic into TestBase #193

Closed vbarua closed 8 months ago

vbarua commented 8 months ago

Reducing test code duplication by moving more common logic into the TestBase abstract class.

vbarua commented 8 months ago

CI is failing due to

/home/runner/work/substrait-java/substrait-java/core/src/test/java/io/substrait/type/proto/LocalFilesRoundtripTest.java:61: error: switch expressions are not supported in -source 8
    return switch (pathTypeCase) {
           ^
  (use -source 14 or higher to enable switch expressions)
/home/runner/work/substrait-java/substrait-java/core/src/test/java/io/substrait/type/proto/LocalFilesRoundtripTest.java:62: error: switch rules are not supported in -source 8
      case URI_PATH -> builder.pathType(FileOrFiles.PathType.URI_PATH).path("path");

which are in code this PR did not touch. Locally, tests run and build fine.

I've seen a number of builds fail with issues like this. In theory Jabel should be converting this code, but it doesn't seem to fire sometimes.

vbarua commented 8 months ago

Filed https://github.com/substrait-io/substrait-java/issues/195 for the build issue.