My attempt to take a stab at the TODO in the code:
// TODO: define up-converting matchers.
We've got here since we noticed that functions that have list<any1>, any1 arguments wouldn't match list<string>, string without implementing a proper CallConverter as adapter:
The FunctionConverter was not matching using directMatchKey since list_any != list_str.
When falling back to the leastRestrictive logic, list<string> + string would also not agree, so no functions were returned.
I've kept the leastRestrictive logic intact, but added another fallback matcher that checks if all arguments will match (using the existent isMatch logic, which relies on IgnoreNullableAndParameters internally).
--
Let me know if there are any concerns or thoughts on how to make this better.
My attempt to take a stab at the
TODOin the code:We've got here since we noticed that functions that have
list<any1>, any1arguments wouldn't matchlist<string>, stringwithout implementing a properCallConverteras adapter:The
FunctionConverterwas not matching usingdirectMatchKeysincelist_any!=list_str.When falling back to the
leastRestrictivelogic,list<string>+stringwould also not agree, so no functions were returned.I've kept the
leastRestrictivelogic intact, but added another fallback matcher that checks if all arguments will match (using the existentisMatchlogic, which relies on IgnoreNullableAndParameters internally).--
Let me know if there are any concerns or thoughts on how to make this better.