search

substrait-io / substrait-java

Apache License 2.0
72 stars 70 forks source link

integrate PrecisionTimestamp and PrecisionTimestampTZ into Isthmus #246

Closed vbarua closed 3 weeks ago

vbarua commented 2 months ago

The changes in https://github.com/substrait-io/substrait-java/pull/247 added POJOs for PrecisionTimestamp and PrecisionTimestampTZ but did not integrate them into Isthmus.

ViggoC commented 1 month ago

I'm working on this issue in https://github.com/substrait-io/substrait-java/pull/262, and encountering some problems related to the precision range. There are some precision checks in TypeConverter, eg. decimal and timestamp, but I don't think it's a good idea to hardcode the limit in a converter tool.