substrait-io / substrait-java

Apache License 2.0
75 stars 72 forks source link

fix: handle LIMIT ALL queries using sentinel value in FetchRel::count #252

Closed vbarua closed 5 months ago

vbarua commented 5 months ago

FetchRels with no count set could not be distinguished from FetchRels with count set to 0.

To account for this, the spec now uses -1 as a sentinel value for this.

feat: new limit and offset methods on SubstraitBuilder

vbarua commented 5 months ago

This work is based on changes introduced in https://github.com/substrait-io/substrait/pull/627