feat(core): shade ANTLR runtime into substrait-core

substrait-io / substrait-java

Apache License 2.0

75 stars 72 forks source link

feat(core): shade ANTLR runtime into substrait-core #260

Closed bestbeforetoday closed 4 months ago

bestbeforetoday commented 4 months ago

An external dependency on a specific ANTLR runtime version can cause version conflicts for consuming projects that also make use of ANTLR. This change shades the ANTLR runtime into the substrait core JAR file, renaming the ANTLR runtime packages to avoid conflicts with any ANTLR dependency in consuming projects.

Closes #259

bestbeforetoday commented 4 months ago

This change has issues and I think the solution in PR #258 works better so closing this PR.