search

substrait-io / substrait-java

Apache License 2.0
75 stars 72 forks source link

fix: properly support Options for Scalar/Aggregate/Window functions #278

Closed Blizzara closed 2 months ago

Blizzara commented 3 months ago

Options were supported in the Java immutables but in most cases dropped when converting into protobuf

This

Blizzara commented 2 months ago

@vbarua did you have a chance to give this another look? :)

Also, any ideas why the editorconfig check is complaining? The files it mentions seem unrelated to this PR:

Run editorconfig-checker
.gitmodules:
    2: Wrong indent style found (tabs instead of spaces)
    3: Wrong indent style found (tabs instead of spaces)
core/src/main/antlr/SubstraitType.g[4](https://github.com/substrait-io/substrait-java/actions/runs/9796466765/job/27050988486?pr=278#step:4:5):
    110: Wrong indent style found (tabs instead of spaces)
...
vbarua commented 2 months ago

any ideas why the editorconfig check is complaining?

Not only where they unrelated to your PR, they also haven't been modified in a long time. I've fixed the issues in: https://github.com/substrait-io/substrait-java/pull/280