search

substrait-io / substrait-validator

Apache License 2.0
8 stars 8 forks source link

chore: release 0.1.0 #295

Closed wackywendell closed 3 weeks ago

wackywendell commented 3 weeks ago

This PR

Closes #290.

This PR is:

  1. First commit is purely codegen from running python ci/version.py set 0.1.0.
  2. Second commit updates the repository info in Cargo.toml, which appears on crates.io
  3. Third commit updates the substrait compatibility matrix in the README

I went with 0.1.0 because the jump in substrait version supported like more than just a patch version change, although I'm not sure it matters pre-1.0; if others have opinions, it would be trivial to switch this to 0.0.12 instead.

Releasing

After this is merged, based on what I saw earlier, I think all we need to do is add a tag (e.g. via the Github web interface) of the form v*.*.* and CI should take it from there - building and publishing to crates.io and to PyPI.

Followup

  1. Fix any issues with CI if release doesn't go smoothly
  2. Update the docs to clarify that adding a tag is enough to trigger an automated release.
wackywendell commented 3 weeks ago

One question: can you also update the https://github.com/substrait-io/substrait-validator?tab=readme-ov-file#substrait-version-support section in this PR?

Ah, yes, good catch! Will do.

mbrobbel commented 3 weeks ago

Rust: https://github.com/substrait-io/substrait-validator/actions/runs/11711071490 ✅ Python: https://github.com/substrait-io/substrait-validator/actions/runs/11711071506 🛑

Looks like we need a fix for the Python wheel artifact issue.

wackywendell commented 3 weeks ago

Looks like we need a fix for the Python wheel artifact issue.

Hm, yes. I'm not quite sure what the problem is - it might be that we have N jobs attempting to upload wheels.zip, and only one can succeed? So perhaps they should each be attempting to upload wheels-${ARCH}-${PYTHON_VERSION}?

mbrobbel commented 3 weeks ago

This was a breaking change in the v4 release of the download/upload artifact actions: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

There are some suggestions in https://github.com/actions/upload-artifact/issues/480.

I added https://github.com/substrait-io/substrait-validator/issues/296.

wackywendell commented 3 weeks ago

Judging from here, it looks like dependabot's upgrade of actions/upload-artifact from 3 to 4 led to this:

Unlike earlier versions of upload-artifact, uploading to the same artifact via multiple jobs is not supported with v4

…

Artifact names must be unique since each created artifact is idempotent so multiple jobs cannot modify the same artifact.

I'm happy to make a PR here, although you know this part of the code better than I do, @mbrobbel!