search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.2k stars 156 forks source link

feat: add timestamp in max/min function #511

Closed icexelloss closed 1 year ago

icexelloss commented 1 year ago

This PR add supports for timestamp types in max/min function.

This is currently supported in Acero and I believe most databases support this as well.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 1 year ago

ACTION NEEDED

Substrait follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

westonpace commented 1 year ago

After sleeping on this I think the best course of action is to proceed with this PR as it is and we can address the any approach at some future date if needed.

icexelloss commented 1 year ago

Thanks @westonpace and @gforsyth !