Open gforsyth opened 1 year ago
I think we should try to avoid footguns. Given that we don't define a character encoding, case conversions are not well-defined.
Should
i8
be equivalent toI8
?
No. It would be confusing to me if they were.
Should we require them to be lowercase?
No. I would be confused by a restriction here, if the matching is defined to be exact ("plain binary matching").
504 led to a discussion in one of the fortnightly calls about how to perform matching:
Snippet from the agenda notes from the Substrait fortnightly meeting on May 24th, 2023:
the general consensus was that we should preserve case in matching function names, e.g.
ADD ~= add
.We also (relatively) recently codified that option names perform case insensitive matching. It was also discussed in the meeting that having inconsistent matching rules is not great for anyone.
Does anyone have any feelings about whether datatypes should also be matched exactly?
Should
i8
be equivalent toI8
? Should we require them to be lowercase?Items to do for this: