search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.19k stars 155 forks source link

feat: add radians and degrees functions #544

Closed richtia closed 1 year ago

richtia commented 1 year ago

PR to add radians and degrees functions

richtia commented 1 year ago

Is it worth putting these functions in a new file (extensions/geometric.yaml perhaps) to keep the file size down? Two small functions aren't going to make much of a difference though.

I thought these made more sense going next to the trig functions. I was planning on adding mostly geospatial functions from postgis to the geometric yaml.

EpsilonPrime commented 1 year ago

Works for me.

EpsilonPrime commented 1 year ago

thanks @richtia! this looks good to me!

@EpsilonPrime -- does this need PMC approval since it's not changing existing functionality?

Technically probably since it adds functionality. But given that this isn't controversial I don't think anyone would mind.

EpsilonPrime commented 1 year ago

thanks @richtia! this looks good to me! @EpsilonPrime -- does this need PMC approval since it's not changing existing functionality?

Technically probably since it adds functionality. But given that this isn't controversial I don't think anyone would mind.

Hmm, but a reread of substrait.io/governance does explicitly state that addition of a non-breaking function merely requires one committer to approve. So we should be good to merge this one.