substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.14k stars 148 forks source link

chore: remove unnecessary commit title checks #588

Closed westonpace closed 7 months ago

westonpace commented 7 months ago

The PR title check makes sure that the eventual commit message that Github generates follows our commit message rules. To do this we have to emulate the way that Github creates commit messages (by combining the PR title with the description).

In practice, Github also applies appropriate line-wrapping to ensure that no line in the commit message is too long. Unfortunately, our emulation doesn't do this. As a result, we have to write strangely truncated descriptions in Github and this is mildly annoying.

Instead, we can just disable these rules. They are enforced by Github anyways when the commit message is created and so it isn't really possible to break them (unless you use a single word with more than 80 characters but hopefully a reviewer will notice that).