search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.14k stars 148 forks source link

feat: include precision parameter in timestamp types #594

Closed richtia closed 6 months ago

richtia commented 7 months ago

This PR introduces a new PrecisionTimestamp type that accepts an optional precision parameter to specify fractional second precision.

Closes https://github.com/substrait-io/substrait/issues/592

github-actions[bot] commented 7 months ago

ACTION NEEDED

Substrait follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

richtia commented 7 months ago

Keeping this as a draft and only making the changes for Timestamp as of right now. Once we agree on what changes need to be made, I'll make the updates for Timestamp_tz as well.

richtia commented 6 months ago

As part of this, do we need add signature names for the new types as well?

https://github.com/substrait-io/substrait/blob/d9b9672fd3c24285afdee9344fc2f4f7fcd70afb/site/docs/extensions/index.md#L73-L74

Thanks for the catch! Added new signature names