search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.14k stars 148 forks source link

docs: clarify nullability information source for empty literals #602

Closed vbarua closed 4 months ago

vbarua commented 6 months ago

Looking at the oneof literal_type block I noticed that the empty_list variant and empty_map variant reuse a Type message, much like the null variant.

      Type null = 29; // a typed null literal
      ...
      Type.List empty_list = 31;
      Type.Map empty_map = 32;

Like Type, Type.List and Type.Map also declare their nullability directly. To avoid ambiguity, I updated the docs to specify that the nullability of these literals should come from the inner message here, and not from the nullable field of the Literal message.

github-actions[bot] commented 6 months ago

ACTION NEEDED

Substrait follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

vbarua commented 5 months ago

I want to double check something before merging this, will look at it this week.

vbarua commented 4 months ago

I want to double check something before merging this, will look at it this week.

Weston's suggestion clarified this for me. I think this should be good as is with his changes incorporated.

EpsilonPrime commented 4 months ago

Will check this on Thursday.