add a CI check to lint function extensions

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.

https://substrait.io

Apache License 2.0

1.18k stars 154 forks source link

add a CI check to lint function extensions #633

Open vbarua opened 5 months ago

vbarua commented 5 months ago

A number of PRs have introduced changes to functions extensions which don't conform to the spec. The most recent example was https://github.com/substrait-io/substrait/pull/247.

Manual review has proven insufficient to catch these issues, and honestly we shouldn't rely on manual review when we can have a lint for these issues instead.

Things we might wish to lint for:

Invalid Type Names
Duplicate Functions Definitions