search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.16k stars 150 forks source link

feat: split unbounded bound into lower and upper #691

Closed EpsilonPrime closed 3 weeks ago

EpsilonPrime commented 3 weeks ago

BREAKING CHANGE: splits the WindowFunction Unbounded bound into preceding and following types.

The intention of the unbounded bound type was to work two ways depending on whether the bound type was preceding or following. However since the preceding and following types are part of the same one of structure this was not possible.

EpsilonPrime commented 3 weeks ago

After checking the substrait-java code for how they handle unbounded_preceding and unbounded_following, it's clear that the existing definition works just fine. I will clean up the corresponding change here from the Gluten code.