search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.21k stars 160 forks source link

feat: make substrait repo a go module #712

Closed anshuldata closed 1 month ago

anshuldata commented 2 months ago

This facilitates substrait assets use in go projects

zeroshade commented 2 months ago

You can use a replace directive in the go.mod locally to point it at this branch. If you need I can provide the exact commands tomorrow via go mod edit to help out.

anshuldata commented 2 months ago

Looks good to me. Have you confirmed that you can use this in substrait-go? I believe you can do a go get against your fork+hash somehow and test.

yes, I confirmed by creating a module which has same go.mod and core.go and accessing that referring this module in substrait-go. "go get" gets to local cache and pushes to go package repository too

Screenshot 2024-09-27 at 10 56 46 AM
anshuldata commented 2 months ago

You can use a replace directive in the go.mod locally to point it at this branch. If you need I can provide the exact commands tomorrow via go mod edit to help out.

yes, I tested it using "replace" directive to locally point to this repo

jacques-n commented 1 month ago

@zeroshade , look good to you?

jacques-n commented 1 month ago

Comment seems useful. I'm inclined to avoid adding any tests/extra stuff here. Really figure people will primarily use via substrait-go as opposed to direct.

anshuldata commented 1 month ago

It also might be worthwhile adding a package level comment and maybe a testable example showing how to use the FS? Added comment

I'm inclined to avoid adding any tests/extra stuff here I have skipped adding test case