substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.21k stars 160 forks source link

Specify row_number as 1-based #722

Closed tokoko closed 1 month ago

tokoko commented 1 month ago

row_number function doesn't specify whether the numbers start at 1 or 0. While most engines do start at 1, I think it's still worth being explicit here. ibis for example normalizes row numbers to start at 0 instead of 1.

vbarua commented 1 month ago

The spec has been updated!