search

substrait-io / substrait

A cross platform way to express data transformation, relational algebra, standardized record expression and plans.
https://substrait.io
Apache License 2.0
1.21k stars 160 forks source link

feat: add substrait test files to go embedded fs #740

Closed scgkiran closed 1 week ago

scgkiran commented 1 week ago

So the purpose of this PR is to make the function compliance tests visible to the Go module for use by systems wanting to run the compliance checks elsewhere?

Yes

That's fine with me but I wonder if it should be a separate Go module so that folks only wanting the definitions can get to them separately. It would be additionally nice if we could keep the non-definition files out of the root directory for the repository.

I felt its too small to make it a separate module. I moved tests to a new embedFS.