search

substrakt / letsencrypt-heroku

Make any Heroku application secure in just a couple of minutes.
https://substrakt.com/heroku-ssl-me-weve-come-a-long-way/
MIT License
524 stars 19 forks source link

Root domain #20

Closed reverofevil closed 7 years ago

reverofevil commented 7 years ago

What should I specify in subdomains query parameter, if the domain I'd like to get a certificate for is domain.tld, without any www. etc.?

samknight commented 7 years ago

I believe root domain is done whether or not a subdomain is stated

reverofevil commented 7 years ago

@samknight Well, guessing is a bad thing when it comes to security. I didn't guess, took a proper certbot distro and got SSL running via manual process. It seems

This is alpha software.

message is not the result of authors being humble.

samknight commented 7 years ago

Root domains worked for me when I got this working last night hence why I couldn't confirm at that moment.

Feel free to create a pull request if you want to help make this more stable for your needs.

maxehmookau commented 7 years ago

Indeed, the warning about this being alpha was a clear statement and nothing to do with humility I'm afraid!

By default, root domains are always covered. Subdomains are optional.

reverofevil commented 7 years ago

@maxehmookau Just add some code that defaults subdomains to an empty list if it's absent in the query, please. It will make the process a little bit more obvious.

maxehmookau commented 7 years ago

It's on our list to do but we have lots of other projects that we work on currently both public and private. If it's an urgent concern then feel free to submit a pull request with the change otherwise it'll happen when our schedule allows. Generally speaking we work on our OSS projects on a Tuesday. Thank you for bringing it to our attention.