substrakt / letsencrypt-heroku

Make any Heroku application secure in just a couple of minutes.

https://substrakt.com/heroku-ssl-me-weve-come-a-long-way/

MIT License

524 stars 19 forks source link

proposed fix for debug flag #23

Closed johnnagro closed 7 years ago

johnnagro commented 7 years ago

22

samknight commented 7 years ago

👍

maxehmookau commented 7 years ago

Thank you for this!

I like this but I'm wondering If maybe we switch the logic round so that the default is to use the test API since the live one is quite aggressively rate limited.

Thoughts @samknight ?

samknight commented 7 years ago

I think default should still be live. I don't see much benefit in the test server since a self signed certificate then uploads onto a site which may already be live. Debug to me should be more verbose output rather than test servers.

This was something I was going to discuss at a later point. But for those reasons I think default should be live.

maxehmookau commented 7 years ago

Yeah, that's a fair point. I’ll merge this then!