Starlight v2 - Githubissues

substrant / starlight

Roblox multitool. Custom Roblox launcher and bootstrapper.

BSD 3-Clause "New" or "Revised" License

13 stars 1 forks source link

Starlight v2 #25

Open reversed-coffee opened 1 year ago

reversed-coffee commented 1 year ago

This is a draft branch and there's a good chance that cloning branch v2 will result in highly unstable, buggy, and half-written code. Anything built under this branch is not meant to be permanent. Refer to the main branch for the latest stable version of Starlight.

This PR will not be merged because I'm slow and don't know how to do things right. This will be force pushed to the main branch upon completion.

reversed-coffee commented 1 year ago

Current plans:

Refactor from the bottom-up and clean up any redundant code.
Document all public API code with inline documentation.
Make every single function run asynchronously with CancellationToken support.
Completely redo exception throwing, catching, etc.
Reimplement logging.
Implement a synchronous namespace to run all functions synchronously.

reversed-coffee commented 1 year ago

Finished refactoring Starlight.Apis. Bugs are expected.

reversed-coffee commented 1 year ago

Self-note: sometime later just completely rewrite ClientInstance.cs because it's messy. Don't implement CancellationToken support for it before rewriting.

reversed-coffee commented 1 year ago

Note: don't merge this you'll have to reset the main branch because you're stupid.

reversed-coffee commented 1 year ago

Bug: freezes when getting task scheduler idk why but note to self to fix it.

reversed-coffee commented 1 year ago

Forgot to turn on my home computer before school so I can't work on it remotely today. I have unpushed commits.

Edit: backwards-incompatible changes were made. Don't use ClientScope.

reversed-coffee commented 1 year ago

Took a bit of a break; I'll probably start working on it again but my school firewall blocked my IP (probably from all the bandwidth) so I won't be doing it at school right now.

reversed-coffee commented 1 year ago

Many of the changes to Starlight at this time are uncommitted changes I made to the HackerFramework dependency to make interoperability easier and memory scan speeds faster.