search

substrate-developer-hub / substrate-cms

5 stars 5 forks source link

Add Subsocial to Substrate users #25

Closed siman closed 4 years ago

siman commented 4 years ago

Similar changes as in this PR: https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/pull/526

maxsupera commented 4 years ago

hey @JoshOrndorff, please make sure you check the pr branch locally to make sure nothing breaks before merging with master. in this case, the image field was pointing to a svg that didnt exist, instead of the png file that is there, which broke that page. i've fixed it and pushed to master...

siman commented 4 years ago

OMG, sorry, I will fix this real quick

maxsupera commented 4 years ago

OMG, sorry, I will fix this real quick

@siman its cool ive already fixed it! just for future reference...

thanks!

siman commented 4 years ago

@thisisvilla I just uploaded SVG actually :) SVG is better than PNG in some cases. https://github.com/substrate-developer-hub/substrate-cms/pull/26

maxsupera commented 4 years ago

@siman sure either way. im importing and transforming pngs at build time so either works. Ive also just added a conditional, so if there is a break because of a mistype, it wont break the whole page... it just shows the circle without a logo. :D

maxsupera commented 4 years ago

@thisisvilla I just uploaded SVG actually :) SVG is better than PNG in some cases.

26

@siman is this just replacing the file, or did you change the reference to the file in substrate-users.json back to .svg as well?

edit: ive merged and updated the substrate-users files back to svg. in the future, please make sure the file name and extension referenced matches the file. Thanks!

maxsupera commented 4 years ago

@thisisvilla I just uploaded SVG actually :) SVG is better than PNG in some cases.

26

in regards to this, i would actually prefer to have png files with transparent backgrounds. i can transform those into anything and they present no security risks. SVG files contain code that can be malicious if not thoroughly checked or sanitized: https://blog.online-convert.com/svg-file-and-its-danger/

subsocialdev commented 4 years ago

SVG files contain code that can be malicious if not thoroughly checked or sanitized

Interesting. So now you have both our SVG and PNG. You can use PNG, no problem.

maxsupera commented 4 years ago

@subsocialdev awesome! thanks! 🙌