substratusai / lingo

Lightweight ML model proxy and autoscaler for kubernetes
https://www.substratus.ai
Apache License 2.0
102 stars 6 forks source link

Fix race condition in test #55

Closed alpe closed 6 months ago

alpe commented 6 months ago

Resolves #53

🤔 interesting. It was not causing any problems on my box. I was using Go go1.21.5 + go1.21.6 darwin/arm64. Only when I added a time.Sleep(time.Millisecond) before the second startTogether call, I can reproduce the issue. Sorry for this.

I found a similar scenario on stackoverflow that helped to resolve the issue.

nstogner commented 6 months ago

Thanks for quick fix! I can no longer reproduce the race on my local machine. Merging.