search

subtleGradient / language-javascript-jsx

JavaScript with JSX Bundle for Atom
45 stars 6 forks source link

Syntax highlight on jsx attributes #1

Closed yemi closed 9 years ago

yemi commented 9 years ago

First of all, thank you for this package, I haven't found any other package that adds syntax highlighting for jsx AND es6, so thanks..

There is probably only one thing that im missing currently and that is highlighting on attributes on jsx elements.

Currently it looks like this and it gets a little messy after a while. screen shot 2014-11-29 at 11 19 38

subtleGradient commented 9 years ago

Thanks!

Try it with my Brilliance White theme. The two work very well together.

These are from my TextMate 2 stuff that I've invested thousands of dollars worth of my time into over the years. Productive procrastination for the win ;)

I agree about the attributes, but it isn't as bad with the other theme. Now that I know I'm not the only person who cares about the problem in much more likely to fix it. But I have no idea when I'll get to it. Sorry

yemi commented 9 years ago

I like the brilliance white theme but i think im just too fond of dark themes to switch.. You don't happen to have a brilliance black theme laying around? ;)

I'm looking forward to that, if it's possible it would make this my go-to syntax theme when developing react apps :+1:

subtleGradient commented 9 years ago

Brilliance Black was actually first. I just haven't gotten around to porting it to Atom yet. I'll let you known when I do. You could always invert the colors of your monitor using the accessibility settings ;)

subtleGradient commented 9 years ago

This should be technically working properly, assuming your theme supports it at least. Please let me know if there's anything else broken.

Thanks much!