`let` styling doesn't match `var`, `const`

[elbeezi]

[SC7639]

+1

[subtleGradient]

I have an update in the works for let, const, and type On Wed, Sep 16, 2015 at 7:59 AM SC7639 notifications@github.com wrote:

+1

— Reply to this email directly or view it on GitHub https://github.com/subtleGradient/language-javascript-jsx/issues/12#issuecomment-140720245 .

[SC7639]

Ok brilliant! I've added it in the mean time to my own manually

[davidhariri]

Status on this?

[subtleGradient]

Fixed in the upstream, but I haven't synced changes down recently. I'll try to get to that soon. Sorry for the delay

[onedr0p]

+1

@subtleGradient please update this, I know you haven't been active in months, but when you get the time, please find the time to update.

[lyquocnam]

let keyword still not style...

[benpptung]

I can confirm let styling is an issue, and this is what I see via Developer tool.

Before this package was installed. The hierarchy classes in a line:

classes for const

syntax--source syntax--js
    syntax--storage syntax--type syntax--const syntax--js

classes for variable following const

syntax--source syntax--js
    syntax--constant syntax--other syntax--js

classes for let

syntax--source syntax--js
    syntax--meta syntax--method-call syntax--js
        syntax--meta syntax--arguments syntax--js
            syntax--storage syntax--type syntax--var syntax--js

classes for variables following let

syntax--source syntax--js
    syntax--meta syntax--method-call syntax--js
        syntax--meta syntax--arguments syntax--js

After this package installed:

classes for const

syntax--source syntax--js syntax--jsx
    syntax--storage syntax--modifier syntax--js

classes for variable following const

syntax--source syntax--js syntax--jsx
    syntax--variable syntax--other syntax--readwrite syntax--js

classes for let

syntax--source syntax--js syntax--jsx
    syntax--variable syntax--other syntax--readwrite syntax--js

classes for variables following let

syntax--source syntax--js syntax--jsx 
    syntax--variable syntax--other syntax--readwrite syntax--js

After this package installed, I tried to style let, however, based on the above classes, it seems not possible to distinguish let from the variable following let, because they are with same classes.

[subtleGradient]

Thanks for looking into this, but I'm not able to fix it at this time. I recommend uninstalling the package and using one of the better maintained packages instead. Sorry for the hassle

On Sun, Aug 20, 2017, 4:31 AM benpptung notifications@github.com wrote:

I can confirm let styling is an issue, and this is what I see via Developer tool.

Before this package was installed. The hierarchy classes in a line: classes for const

syntax--source syntax--js syntax--storage syntax--type syntax--const syntax--js

classes for variable following const

syntax--source syntax--js syntax--constant syntax--other syntax--js

classes for let

syntax--source syntax--js syntax--meta syntax--method-call syntax--js syntax--meta syntax--arguments syntax--js syntax--storage syntax--type syntax--var syntax--js

classes for variables following let

syntax--source syntax--js syntax--meta syntax--method-call syntax--js syntax--meta syntax--arguments syntax--js

After this package installed: classes for const

syntax--source syntax--js syntax--jsx syntax--storage syntax--modifier syntax--js

classes for variable following const

syntax--source syntax--js syntax--jsx syntax--variable syntax--other syntax--readwrite syntax--js

classes for let

syntax--source syntax--js syntax--jsx syntax--variable syntax--other syntax--readwrite syntax--js

classes for variables following let

syntax--source syntax--js syntax--jsx syntax--variable syntax--other syntax--readwrite syntax--js

After this package installed, I tried to style let, however, based on the above classes, it seems not possible to distinguish let from the variable following let, because they are with same classes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/subtleGradient/language-javascript-jsx/issues/12#issuecomment-323571525, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQFQ0bp-HF9zsanmOnoH1UuxlSUD-Bks5sZ-7vgaJpZM4F6gMp .