search

subtleGradient / language-javascript-jsx

JavaScript with JSX Bundle for Atom
45 stars 6 forks source link

syntax problems for quotes in HTML comments #2

Closed giorgian closed 9 years ago

giorgian commented 9 years ago

With this package enabled, a quote (both single and double) in an HTML comment breaks syntax highlighting for the rest of the buffer.

screencast

jzumbrun commented 9 years ago

This issue also affects php comments not just html comments. I had to disable this plugin it is such an annoying issue.

subtleGradient commented 9 years ago

Oh crap. Sorry about that

subtleGradient commented 9 years ago

Oh dang. I don't know how I missed this issue for this long. I need to get better at email or something. Thanks for providing such an awesome bug report with animations and everything!

I'll try to get this fixed asap. Sorry for the delay

subtleGradient commented 9 years ago

This grammar was converted from my TextMate 2 language syntax. Looks like Atom doesn't support all the scope rules that TextMate 2 supports. I'll just disable the JSX in HTML SCRIPT tags for Atom until I can come up with a way to convince Atom to let me do it properly

subtleGradient commented 9 years ago

v0.3.2 should fix this. Sorry again :[

jzumbrun commented 9 years ago

Works, fixed thanks!