search

subtleGradient / language-javascript-jsx

JavaScript with JSX Bundle for Atom
45 stars 6 forks source link

Package is messing with PHP formatting #3

Closed sfw185 closed 9 years ago

sfw185 commented 9 years ago

I initially assumed this bug to be related to the PHP formatter built into Atom, but after some trial and error I tracked it down to this package instead.

See original issue I posted here.

This is one code example that triggers the issue (extracted from a .php file):

// Set address name if it wasn't entered
if (!$location->getAddressOne() && $location->getAddressTwo())
{
    $location->setAddressOne($location->getAddressTwo() ? ' ' . $location->getAddressTwo() : '');
}

$hasAddress = $location->getAddressOne() ? true : false;

Changing the first line of the code to remove the apostrophe corrects the problem:

// Set address name if it wasnt entered
if (!$location->getAddressOne() && $location->getAddressTwo())
{
    $location->setAddressOne($location->getAddressTwo() ? ' ' . $location->getAddressTwo() : '');
}

$hasAddress = $location->getAddressOne() ? true : false;
subtleGradient commented 9 years ago

Fixed in v0.3.2 Sorry :[