Design/Code Review 2

[kodehomie]

Design/Code Review 2

Project: IndieCosmeticProducts

Developer: Subheksha Karki

Reviewer: Justin Hoang

Areas for Improvement	Criteria	Items Met or Exceeded
👍	Project effectively utilizes the technologies and techniques specified in the project objectives	Yes
👍	Planned MVP Functionality	Yes
👍	Logging framework used, i.e., no System.out.println() or printStacktrace() statements.	Yes
👍	Hibernate used for all data access.	Yes
👍	Authentication implemented.	Yes
👍	Consumes at least one web service or public api using Java.	Yes
Just need to integrate into JSP then you are all set👍	Application is database-driven using full CRUD.	Yes
👍	Database includes multiple one to many relationships.	Yes
👍	Deployed to AWS for public access.	Yes
👍	Implements best practices (for example, data validation)	Yes
👍	Synthesis of multiple concepts in unfamiliar situations requiring research beyond the scope of the class	Yes
👍	Experiments individually, exhibits independence and drive, shows originality in the solution.	Yes
👍	Implemented technologies or techniques not covered in course materials.	Yes
👍	Code quality - Evaluate code quality for the following and identify specific areas for improvement (class, method or line number). Be sure to list which code quality plugins/tools you used to assist with this analysis	Yes
👍	Single-purpose methods	Yes
👍	Well-structured project	Yes
👍	Descriptive naming of packages, classes, methods, variables	Yes
👍	Classes appropriately-sized (no monster classes)	Yes
👍	CPD (copy paste detection, meaning are the same lines of code repeated?	Yes
👍	Are there candidates for super/subclass relationships, abstract classes, interfaces	Not yet	are any values hard-coded that should be in a properties file?
👍	Proper exception handling	Yes
👍	Proper error reporting to the user - custom error pages?	Yes
All complete except the ones you are still working on such as location👍	Code documentation	Yes
👍	Is there code in the servlet doGet/doPost that should be refactored into testable classes or methods?	No
👍	Evaluate the JSPs for templating, data validation, overall look and feel.	Yes
👍	JSPs use JSTL and EL, no java code	Yes
👍	Unit tests are truly a unit test rather than a high level functional test	Yes
👍	Test data is appropriately cleaned up or handled	Yes
👍	There is full coverage of methods that perform business logic or utility functions	Yes
👍	Redundant code is eliminated by using set up and tear down methods, i.e., @Before, @After	Yes
☺️	Other comments/notes?	☺️
👍	Demonstrates initiative and thoughtful planning to leverage available resources (time, equipment, external expertise) to meet milestones and project objectives.	Yes
👍	Evidence of significant revision and incorporation of feedback.	Yes
👍	Project complexity	Yes
Additional Comments	Great job, Subu! Now we will work hard to finish the rest of the project👍	☺️

[kodehomie]

Great work, @subu250 ! We are in the final stretch! You can do it; I believe in you🥳

[kodehomie]

@pawaitemadisoncollege

[pawaitemadisoncollege]

@mybffjustin This review lacks some detail to help the developer improve the application, and to demonstrate a thorough review of the application itself..

For example, is the application working properly out on AWS? When I access the application using the link in the indie project list, this is the home page:

Can you identify areas for improvement here? Does authentication work on the was-deployed application?

Which technologies are included that led you to indicate yes for: "Implemented technologies or techniques not covered in course materials."?