search

subugoe / goefis

This repository contains the layers and changes specific to the SUB Goettingen
2 stars 0 forks source link

Our embed function is different from LibreCat (demo) #130

Closed dbeucke closed 7 years ago

dbeucke commented 7 years ago

Demo:

http://demo.librecat.org/person/1234?person=1234&style=apa (strange why I get another person id if I switch to APA!) <div class="publ"><script type="text/javascript" charset="UTF-8" src="http://demo.librecat.org/embed?cql=person%3D1234&cql=person%3D1234&style=apa&fmt=js"></script><noscript><a href="http://demo.librecat.org/embed?cql=person%3D1234&cql=person%3D1234&style=apa" target="_blank">My Publication List</a></noscript></div>

pub-dev:

https://pub-dev.sub.uni-goettingen.de/person/khoff1?style=apa <div class="publ"><script type="text/javascript" charset="UTF-8" src="https://pub-dev.sub.uni-goettingen.de/person/khoff1?style=apastyle=apa&cql=person%3Dkhoff1&fmt=js"></script><noscript><a href="https://pub-dev.sub.uni-goettingen.de/person/khoff1?style=apastyle=apa&cql=person%3Dkhoff1" target="_blank">My Publication List</a></noscript></div>

christianmahnke commented 7 years ago

The problem is generated probably here: https://github.com/LibreCat/LibreCat/blob/master/views/filters.tt#L187

christianmahnke commented 7 years ago

This Problem can be easily be reproduced by adding an alias to a user which contains letters and numbers. If you then use this alias to open the user page, the embed will break.

christianmahnke commented 7 years ago

https://github.com/LibreCat/LibreCat/pull/241