search

subugoe / goefis

This repository contains the layers and changes specific to the SUB Goettingen
2 stars 0 forks source link

Fix JS embed file #50

Closed dbeucke closed 7 years ago

dbeucke commented 7 years ago

Fix export of JS file for embed function.

I suspect wrong line breaks could be the problem. See: https://github.com/subugoe/goefis/commit/c5e60a5796ae4c291f91063eecaf665688475354

nilswindisch commented 7 years ago

There is no JS export. it would be very helpful if you could describe what's broken (actual vs. expected outcome).

If it's about the JS embed, the output works as expected comparing http://pub-dev.sub.uni-goettingen.de/publication?cql_query= with https://pub.uni-bielefeld.de/publication?q=&fmt=html#

dbeucke commented 7 years ago

I tested do embed JS in a TYPO3 site. Follow code was embeded:

Test

And the pub-dev code is not shown in the site: https://dev.adw-goe.de/test/Test%20DAniel/ I see the following mistake:

bildschirmfoto 2016-11-29 um 12 27 40
nilswindisch commented 7 years ago

judging from your screenshot the console shows 3 errors. Would be nice to know what errors.

nilswindisch commented 7 years ago

seems to be a bug not related to goefis, but LibreCat itself.

dbeucke commented 7 years ago

Was fixed in LibreCat