search

subugoe / goefis

This repository contains the layers and changes specific to the SUB Goettingen
2 stars 0 forks source link

Check if Mappings for CLS (and probably some were else) are right #98

Open christianmahnke opened 7 years ago

christianmahnke commented 7 years ago

This is not a blocker for the staging.

We need to check if the document type mappings for citations are correct, currently document 7, is returned as a 'book', see: http://pub-dev.sub.uni-goettingen.de/livecitation?id=7&style=ama&debug=1

njahn82 commented 7 years ago

Good news, I installed the docker dev image and the mapping works as intended. I guess we simply need to update the records, so that the new mappings become productive.

christianmahnke commented 7 years ago

Bad news: In 0.3.1 this breaks: https://github.com/LibreCat/LibreCat/issues/168

njahn82 commented 7 years ago

Played around with the patch workflow today. Because I can access the sources and error logs via Docker we can try our best without it (there are many citeproc error messages, I don't understand)

Am 17.02.2017 4:43 nachm. schrieb "christianmahnke" < notifications@github.com>:

Bad news: In 0.3.1 this breaks: LibreCat/LibreCat#168 https://github.com/LibreCat/LibreCat/issues/168

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/subugoe/goefis/issues/98#issuecomment-280684480, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn8RuXRxkr50_b_qbBUAVDV6vRl2Nazks5rdcA5gaJpZM4MDC0t .

christianmahnke commented 7 years ago

My proposal ist to postpone it a week or so and hope they fix it. Or do you think we need it for staging? Or do you need it? I can give you such a server with memory caching, it should be really fast, it's here: https://github.com/subugoe/goefis-datatools/tree/master/citeproc-nginx

njahn82 commented 7 years ago

Yes, the livecitation is a super minor. We have some styles working, and I will submit a ticket asking them to provide guidance how to add styles.

On 17 February 2017 at 17:39, christianmahnke notifications@github.com wrote:

My proposal ist to postpone it a week or so and hope they fix it. Or do you think we need it for staging? Or do you need it? I can give you such a server with memory caching, it should be really fast, it's here: https://github.com/subugoe/goefis-datatools/tree/master/citeproc-nginx

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/subugoe/goefis/issues/98#issuecomment-280700319, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn8RjxE0iRSgKR_4tpIjpkAmUOX0tF_ks5rdc0mgaJpZM4MDC0t .

njahn82 commented 7 years ago

We need to add an language field, so that non-english titles are not displayed in title case http://docs.citationstyles.org/en/stable/specification.html#non-english-items

christianmahnke commented 7 years ago

Is this something, that would improve LibreCat? Something that they can benefit from as well?

njahn82 commented 7 years ago

Yeah, guess I need to add something to the fix file. Will try and if succesful create a PR for LibreCat core

Am 22.03.2017 5:52 nachm. schrieb "christianmahnke" < notifications@github.com>:

Is this something, that would improve LibreCat? Something that they can benefit from as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/subugoe/goefis/issues/98#issuecomment-288464694, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn8RsWUPEHOUQFKvm_ZCc0ewL0W1d9zks5roVHhgaJpZM4MDC0t .

njahn82 commented 7 years ago

https://github.com/LibreCat/LibreCat/issues/224